Warn about GIRA service issues before feedback/email#67
Merged
Conversation
People frequently contact us about GIRA service issues (trips not ending, maintenance, account problems) that we can't help with, since the app is unofficial and not affiliated with EMEL. Show a warning dialog when opening the feedback (GitHub issues) link in the profile menu and the contact email in the about page, redirecting GIRA service questions to EMEL via a tappable gira@emel.pt link.
The trigger anchors preventDefault on click, so their href never navigated — the real navigation is the dialog's Continue link. The feedback entry was also an invalid <button> nested in an <a> (since ProfileMenuEntry is itself a button). Use ProfileMenuEntry's onclick directly (like the History/Settings entries) and make the about-page email icon a <button>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We keep getting emails and GitHub issues about the GIRA service itself — trips not ending, bike/dock maintenance, charges, account problems — which we can't help with, since the app is unofficial and not affiliated with EMEL. Many users have forgotten we're not EMEL.
What
Show a warning dialog before the two main "reach out to us" actions, nudging GIRA-service questions toward EMEL instead:
mailto:contact@gira-mais.app)The dialog explains the app is unofficial and lists the kinds of problems we can't address, pointing users to EMEL via a tappable
gira@emel.ptlink. Cancel dismisses; Continue anyway proceeds to the original destination.Implementation notes
ServiceWarningDialog.svelte, shown via the existingenqueueDialogqueue (same pattern as the other dialogs).<a href>, preserving the app's native external-link /mailto:handling exactly as before — the trigger just intercepts the click to show the dialog first.mailto:link via{@html}(same approach asInfoDialog.svelte); content is fully static, so no injection surface.Verification
bun run check(svelte-check): 0 errors, 0 warningseslintclean on all touched files